Support Prism as a Ruby parser #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
support_prism
branch
3 times, most recently
from
75e8042
to
d385eab
Compare
8 tasks
koic
force-pushed
the
support_prism
branch
2 times, most recently
from
e089ad7
to
41e3a1f
Compare
Follow up rubocop/rubocop-ast#277 Internally, the Parser gem API is used directly to parse db/schema.rb. This has been replaced with `RuboCop::AST::ProcessedSource` from RuboCop AST 1.31, which is compatible with the Prism parser API of the Parser gem API. This change resolves error (e.g., `uninitialized constant Parser::Ruby33`) related to db/schema.rb parsing when Prism is specified as the parser engine, enabling paring with Prism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up rubocop/rubocop-ast#277
Internally, the Parser gem API is used directly to parse db/schema.rb. This has been replaced with
RuboCop::AST::ProcessedSourcefrom RuboCop AST 1.31, which is compatible with the Prism parser API of the Parser gem API.This change resolves error (e.g.,
uninitialized constant Parser::Ruby33) related to db/schema.rb parsing when Prism is specified as the parser engine, enabling paring with Prism.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.