[Fix #370] Fix an incorrect autocorrect for Performance/RedundantMatch
#371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Sep 15, 2023
Comment on lines
76
to
78
| return requires_parentheses_for_call_like?(arg) if call_like?(arg) | ||
|
|
||
| false |
There was a problem hiding this comment.
Can you refactor?
Suggested change
| return requires_parentheses_for_call_like?(arg) if call_like?(arg) | |
| false | |
| call_like?(arg) && requires_parentheses_for_call_like?(arg) |
koic
reviewed
Sep 15, 2023
Comment on lines
82
to
85
| return false if arg.parenthesized? || !arg.arguments? | ||
| return false if HIGHER_PRECEDENCE_OPERATOR_METHODS.include?(arg.method_name) | ||
|
|
||
| true |
There was a problem hiding this comment.
Suggested change
| return false if arg.parenthesized? || !arg.arguments? | |
| return false if HIGHER_PRECEDENCE_OPERATOR_METHODS.include?(arg.method_name) | |
| true | |
| return false if arg.parenthesized? || !arg.arguments? | |
| !HIGHER_PRECEDENCE_OPERATOR_METHODS.include?(arg.method_name) |
ymap
force-pushed
the
fix_an_incorrect_autocorrect_for_performance_redundant_match
branch
from
4742c2a
to
5e13cd1
Compare
…dantMatch` Fixes rubocop#370. This PR fixes an incorrect autocorrect for `Performance/RedundantMatch` when expressions with lower precedence than `=~` are used as an argument.
ymap
force-pushed
the
fix_an_incorrect_autocorrect_for_performance_redundant_match
branch
from
5e13cd1
to
563e8f9
Compare
|
@koic Thanks for the suggestions! Amended the changes. |
|
Thanks! |
ymap
deleted the
fix_an_incorrect_autocorrect_for_performance_redundant_match
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370.
This PR fixes an incorrect autocorrect for
Performance/RedundantMatchwhen expressions with lower precedence than=~are used as an argument.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.