Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #287] don't error on empty blocks when linting assert_raises #288

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Dec 29, 2023

Fixes #287

This fixes Minitest/AssertRaisesCompoundBody erroring on empty blocks


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic
Copy link
Member

koic commented Dec 30, 2023

Looks good to me. Can you squash your commits into one?

@koic koic merged commit d0b6912 into rubocop:master Dec 30, 2023
13 checks passed
@koic
Copy link
Member

koic commented Dec 30, 2023

Thanks!

@G-Rath G-Rath deleted the fix-error branch December 30, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minitest/AssertRaisesCompoundBody cannot handle an empty block
2 participants