Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Minitest/AssertMatch aware of assert_operator #268

Conversation

koic
Copy link
Member

@koic koic commented Oct 2, 2023

This PR makes Minitest/AssertMatch aware of assert_operator.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR makes `Minitest/AssertMatch` aware of `assert_operator`.
@koic koic force-pushed the make_minitest_assert_match_aware_of_assert_operator branch from 7cd806d to b94890b Compare October 6, 2023 15:55
@koic koic merged commit f2396a6 into rubocop:master Oct 8, 2023
10 checks passed
@koic koic deleted the make_minitest_assert_match_aware_of_assert_operator branch October 8, 2023 16:01
@@ -11,6 +11,7 @@ module Minitest
# refute(matcher.match(string))
# refute(matcher.match?(string))
# refute(matcher =~ string)
# refute_operator(matcher, :=~, string)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This included an example that should have been implemented in #269.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant