Enhance AssertMatch/RefuteMatch to check match? and =~ methods
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Feb 13, 2023
| @@ -24,7 +24,8 @@ module MinitestCopRule | |||
| # @api private | |||
| # | |||
| def define_rule(assertion_method, target_method:, preferred_method: nil, inverse: false) | |||
| preferred_method = "#{assertion_method}_#{target_method.to_s.delete('?')}" if preferred_method.nil? | |||
| target_methods = Array(target_method) | |||
| preferred_method = "#{assertion_method}_#{target_methods.first.to_s.delete('?')}" if preferred_method.nil? | |||
There was a problem hiding this comment.
It may be confusing to see the special treatment of the first element. So, the order of the array shouldn't matter for API user.
Perhaps it would be preferable to require preferred_method optional param if more than one element is specified. It might be helpful to add it to the documentation and throw an exception message if it was not specified the option.
There was a problem hiding this comment.
Thanks! Added a check and updated the docs.
fatkodima
force-pushed
the
assert_refute-match-more-methods
branch
from
7a7dde6
to
33c35e8
Compare
koic
reviewed
Feb 14, 2023
| preferred_method = "#{assertion_method}_#{target_method.to_s.delete('?')}" if preferred_method.nil? | ||
| target_methods = Array(target_method) | ||
| if target_methods.size > 1 && preferred_method.nil? | ||
| raise ArgumentError, 'preferred_method should be provided if using more than one target methods' |
There was a problem hiding this comment.
Can you tweak it?
Suggested change
| raise ArgumentError, 'preferred_method should be provided if using more than one target methods' | |
| raise ArgumentError, '`:preferred_method` keyword argument must be used if using more than one target methods.' |
fatkodima
force-pushed
the
assert_refute-match-more-methods
branch
from
33c35e8
to
d871dcd
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239.