Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false positive for Minitest/UselessAssertion when using command execution #237

Merged
merged 1 commit into from Jan 30, 2023
Merged

Fix a false positive for Minitest/UselessAssertion when using command execution #237

merged 1 commit into from Jan 30, 2023

Conversation

fatkodima
Copy link
Contributor

Found a false positive:

assert_empty(`bundle exec yard --no-save --no-output --no-stats`)

https://github.com/fatkodima/sidekiq-iteration/blob/81453f8a5586367ba69c80aeea960fe824b76c40/test/documentation_test.rb#L8

@koic koic merged commit f633c9e into rubocop:master Jan 30, 2023
@koic
Copy link
Member

koic commented Jan 30, 2023

Thanks!

@fatkodima fatkodima deleted the useless_assertion-command-execution branch January 30, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fatkodima @koic