Prism custom builder #354
Merged
Prism custom builder #354
+63
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may emit different ast when used with a ruby version that `parser` doesn't understand, for example `itblock`
That's better than checking if requires succeed, especially now that not only a parser may be missing
Earlopain
force-pushed
the
prism-custom-builder
branch
from
5ad8a41 to
9ac5d47
Compare
Earlopain
force-pushed
the
prism-custom-builder
branch
3 times, most recently
from
d08642b to
a8a6d04
Compare
|
Ah, right. The main gem specs for prism fail because it doesn't use the gemfile from over here and just uses the latest release anyways |
Earlopain
force-pushed
the
prism-custom-builder
branch
from
a8a6d04 to
048e903
Compare
Earlopain
force-pushed
the
prism-custom-builder
branch
2 times, most recently
from
2549117 to
b19a992
Compare
|
This is ready now, prism 1.4.0 got released which contains the necessary changes. One main rubocop spec currently fails for unrelated reasons (rubocop/rubocop#14000). For a bit of context, in rubocop/rubocop#13617 (comment) I wrote what I believe should be the next steps. |
|
Cool, thanks. Released as v1.40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: ruby/prism#3443
I'd like for prism to emit ast for new ruby features, like
it. It's incredibly easy for prism to emititblock, it just needs a custom builder, with a few lines changed to do so. But sincerubocop-astalready uses its own custom builder, they need to play nicely together for it to work.The PR for prism just adds the builder class, without any changes. I'd like to explore that after this.