Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preferred style for hooks ordering #54

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Add preferred style for hooks ordering #54

merged 1 commit into from
Jan 4, 2023

Conversation

tejasbubane
Copy link
Contributor

@andyw8
Copy link
Contributor

andyw8 commented Jan 3, 2023

I wonder if it's better not to mention the after_ and before_ methods (see #47).

@tejasbubane
Copy link
Contributor Author

@andyw8 Makes sense, removed the before_ and after_ methods.

@koic koic merged commit 8e41fb0 into rubocop:master Jan 4, 2023
@koic
Copy link
Member

koic commented Jan 4, 2023

Thanks!

@tejasbubane tejasbubane deleted the hooks-ordering branch January 4, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tejasbubane @andyw8 @koic