Skip to content

Commit

Permalink
Merge pull request #2744 from budu/clean-generator-spec-generator
Browse files Browse the repository at this point in the history
Clean up generator for generator specs
  • Loading branch information
pirj authored and JonRowe committed Mar 18, 2024
1 parent 0ad2229 commit 0cd4b5a
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
4 changes: 2 additions & 2 deletions features/generator_specs/generator_specs.feature
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Feature: Generator spec
create lib/generators/my_generator/USAGE
create lib/generators/my_generator/templates
invoke rspec
create spec/generator/my_generators_generator_spec.rb
create spec/generator/my_generator_generator_spec.rb
"""

Scenario: Use custom generator with customized `default-path`
Expand All @@ -29,5 +29,5 @@ Feature: Generator spec
create lib/generators/my_generator/USAGE
create lib/generators/my_generator/templates
invoke rspec
create behaviour/generator/my_generators_generator_spec.rb
create behaviour/generator/my_generator_generator_spec.rb
"""
4 changes: 2 additions & 2 deletions lib/generators/rspec/generator/generator_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Rspec
module Generators
# @private
class GeneratorGenerator < Base
class_option :generator_specs, type: :boolean, default: true, desc: "Generate generator specs"
class_option :generator_specs, type: :boolean, default: true, desc: 'Generate generator specs'

def generate_generator_spec
return unless options[:generator_specs]
Expand All @@ -17,7 +17,7 @@ def template_name
end

def filename
"#{table_name}_generator_spec.rb"
"#{file_name}_generator_spec.rb"
end
end
end
Expand Down
3 changes: 1 addition & 2 deletions lib/generators/rspec/generator/templates/generator_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
require 'rails_helper'

RSpec.describe "<%= class_name.pluralize %>", <%= type_metatag(:generator) %> do

RSpec.describe "<%= class_name %>Generator", <%= type_metatag(:generator) %> do
pending "add some scenarios (or delete) #{__FILE__}"
end
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
end

it "include the standard boilerplate" do
expect(generator_spec).to contain(/require 'rails_helper'/).and(contain(/^RSpec.describe "Posts", #{type_metatag(:generator)}/))
expect(generator_spec).to contain(/require 'rails_helper'/).and(contain(/^RSpec.describe "PostsGenerator", #{type_metatag(:generator)}/))
end
end
end

0 comments on commit 0cd4b5a

Please sign in to comment.