-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosenpass Protocol Version 2 #145
Open
koraa
wants to merge
22
commits into
main
Choose a base branch
from
dev/karo/protocol-version-2
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…condition handling
…d secrecy This is a minor security fix: Before this change the specification left erasing the secret key to the implementation. The reference implementation did erase `eski` but only after receiving the responder confirmation package (EmptyData at the time) instructing the initiator to stop retransmission of the InitConf package. With this change, `eski` is erased before transmission of the InitConf package.
Fix a typo "key chaining extract" -> "chaining key extract"; "key chaining init" -> "chaining key init"
Issue: #68 (#68 (comment)) pk, shk, ct -> pk, ct, shk
koraa
force-pushed
the
dev/karo/protocol-version-2
branch
from
November 16, 2023 16:32
cb79849
to
87cbd1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs (Karolin):
DescribeRemove Payload transmissionas a possible protocol extensionct
andpk
inencaps_and_mix
? Does CCA2 security imply that the shared key must be tied to ciphertext and public key?Blockers:
Todo Marei (please do not work on those yet):
Todo Mullana (please do not work on these yet):
Add a
abort_initiator_handshake()
call as ICR8 in the protocol steps graphicFigure 2: Add a note to the bottom saying "All numeric values are in little-endian format"
Figure 3: Add short codes from Fig 4; IHI1/IHR1 etc
Figure 3: Add a note pointing people to fig 4 for details about security levels achieved and for the code to use this tree
Figure 3: Introduce a special symbol for the mix, then value sequence and maybe a "zoomed in" explanation.
Figure 4: Get rid of semicolons
Figure 4:
ct1
withsctr
in IHR5Figure 4: Add a step RHI8 to erase the ephemeral secret keys
Figure 4: Add a box with a table indicating when security properties are reached:
/cc @stv0g
Fixes: #68