Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ubuntu 24.04 Noble for GitHub CI #104

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Mar 27, 2024

  • The ubuntu-24.04 GitHub actions runner might not be available until August 2024 (Add Ubuntu 24.04 Noble Numbat actions/runner-images#9691), so just use Docker
  • We seem to now need to explicitly set the default shell to bash to get source to work (possibly due to running in Docker and not the runner itself)

@christophebedard christophebedard self-assigned this Mar 27, 2024
@christophebedard christophebedard marked this pull request as draft March 28, 2024 00:13
@christophebedard christophebedard force-pushed the christophebedard/bump-ci-to-noble branch from 6e69826 to 166b5d3 Compare April 2, 2024 17:24
@christophebedard christophebedard force-pushed the christophebedard/bump-ci-to-noble branch from 166b5d3 to 548529a Compare April 15, 2024 23:47
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard force-pushed the christophebedard/bump-ci-to-noble branch from 548529a to c365385 Compare April 16, 2024 21:16
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard
Copy link
Member Author

Rolling is unfrozen now, so this is ready for review.

Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

if i am not mistaken, workflow is only effective for rolling branch? this is off topic from this PR, but how we can manage the PR against jazzy iron and humble? only CI?

@christophebedard
Copy link
Member Author

Yes, this is only for the rolling branch. Each branch needs to have its own workflow config.

@christophebedard christophebedard merged commit ddb7904 into rolling Apr 23, 2024
9 checks passed
@christophebedard christophebedard deleted the christophebedard/bump-ci-to-noble branch April 23, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants