Update to Foxy, Support Services, QoS, Tf2 via rclcpp and Hololens #84
Conversation
* First commit Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * Support for collections (except string) Signed-off-by: Ubuntu <ubuntu@ros2-eloquent.lxd> * Support for collections (except string) Signed-off-by: Francisco Martin Rico <fmrico@gmail.com> * add return values * first attempt altering Array to work with Sequence; style=poor * update msg.h.em * primitive sequence functionality * Support BasicType Sequences Co-authored-by: Francisco Martin Rico <fmrico@gmail.com> Co-authored-by: Ubuntu <ubuntu@ros2-eloquent.lxd> Co-authored-by: Lou Amadio <lamadio@microsoft.com>
* add return values * Plumb QoS profiles through to C# layer * Debug QoS plumbing * Document profiles * Plumb QoS profiles through to C# layer * Debug QoS plumbing * Document profiles * conventions refactor Co-authored-by: Lou Amadio <lamadio@microsoft.com>
* add return values * (broken) in progress nested type sequences * Add support for sequences of namespaced types Co-authored-by: Lou Amadio <lamadio@microsoft.com>
* add return values * (broken) in progress nested type sequences * Add support for sequences of namespaced types * Expose TransformListener interface from tf2 to C# * C# portion of tf interface * clean up interface and document Co-authored-by: Lou Amadio <lamadio@microsoft.com>
* Adding Service support. WIP. * Changes compiling. Beginning testing. * Able to roundtrip service request and response. * End to end client with server working. * Cleaning up some error handling. * Adding shutdown cleanup logic. * Copyright notices. Fixes for add of shutdown logic. Co-authored-by: Stuart Schaefer <stscha@microsoft.com>
|
@ooeygui thanks for the PR. I had a brief look at it, but it's really difficult to review a PR this big which touches so many things at the same time and adds multiple features, could you break it down to individual PRs? Thanks. Also, depending on |
|
As many of these are interconnected; I'll see what we can do to split it out. |
|
I'd be happy to schedule an virtual live review if that would help get through this PR. |
@ooeygui these features were added as separate PR in your fork, so it should be straightforward to replicate that onto upstream. For example, QoS was introduced in ms-iot#2, why not just resubmit that PR onto this repository? It's ok if PRs depend on each other, as long as they have a clear goal and can be discussed in isolation. There are over 3000 additions in this PR, it's a massive diff, I'm quite sure if someone in your team sent a PR this big it wouldn't go through easily.
Thanks, but let's try going the usual route of using GitHub, a live review of over 3000 additions is gonna be quite intense. |
|
@esteve Please forgive my miscommunication about the license. Microsoft by default will contribute new code under MIT, but I have verified that Apache is fine as well. As I break up the original code drop in #84, I'll rewrite the license headers so that it is not mentioned. I have left PR 84 for the conversation history; however, if you want to close it to keep the noise down in the repo, that's fine too. I'm planning on addressing the CI issues independently first; I did see you had made progress on the Linux side; I'll build off that for Windows and UWP. Thank you |
|
Converted this to a draft so it isn't accidentally pulled. |
|
Hello. |
|
Closing this as it is out of sync with the main branch by merging my two PRs:
QoS is already implemented in #94 if someone want's to checkout this branch, should be split out into a seperate PR in the next weeks. For TF2 we have a separate repository that binds to the c++ classes. TF2 should not be part of the core Thanks for your contributions non the less, even if it didn't get merged! |
No description provided.