Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working to bring CI back to green #1015

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Working to bring CI back to green #1015

merged 11 commits into from
Mar 15, 2024

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Jan 2, 2024

It's failing with several recent changes. This PR is to just try to resolve that and unblock other changes.

I think python 2.7, empy 4.x and possibly setuptools/pip are updated/need updating.

@tfoote
Copy link
Member Author

tfoote commented Jan 2, 2024

I've gotten everything back to green except ROS 2 Doc

Which is showing a real failure on the farm: https://build.ros2.org/view/Rdoc/job/Rdoc__rcl__ubuntu_jammy_amd64/81/console

03:57:55 /home/buildfarm/.local/lib/python3.10/site-packages/breathe/project.py:116: RemovedInSphinx80Warning: Sphinx 8 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.
03:57:55   self._default_build_dir = os.path.dirname(app.doctreedir.rstrip(os.sep))
03:57:56 /home/buildfarm/.local/lib/python3.10/site-packages/exhale/configs.py:1408: RemovedInSphinx80Warning: Sphinx 8 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.
03:57:56   _one     = containmentFolder == app.srcdir
03:57:56 
03:57:56 Extension error (exhale):
03:57:56 Handler <function environment_ready at 0x7f1ce81cc430> for event 'builder-inited' threw an exception (exception: startswith first arg must be str or a tuple of str, not _StrPath)
03:57:56 Sphinx-build exited with return code '2'

This looks like something to do with the python transition to path objects instead of string representations of paths between something generated and exhale.

@claraberendsen
Copy link

It seems like the version being installed on CI is 7.2.6 that has a change of logic from str to pathlib.Path paths (sphinx-doc/sphinx#11605). Breathe has not yet addressed this drift (breathe-doc/breathe#943), however version 7.3 of sphinx has a workaround this.

cottsay and others added 6 commits March 13, 2024 16:12
It generally works but it's not an officially supported configuration so we don't want to block CI for those cases. 

Especially here it's failing on a system package deprecation.

```
 #22 16.62 E: Package 'python3-pytest-rerunfailures' has no installation candidate
  #22 ERROR: process "/bin/sh -c for i in 1 2 3; do apt-get update && apt-get install -q -y python3-pytest-rerunfailures && apt-get clean && break || if [ $i -lt 3 ]; then sleep 5; else false; fi; done" did not complete successfully: exit code: 1
```
It will fail but it's actually broken
@tfoote
Copy link
Member Author

tfoote commented Mar 15, 2024

Merging to get CI back to mostly green with a tracker for the one remaining issue: #1029

@tfoote tfoote merged commit f8d8219 into master Mar 15, 2024
30 of 31 checks passed
@tfoote tfoote deleted the fix_ci branch March 15, 2024 18:33
@nuclearsandwich
Copy link
Contributor

Thank you!

nuclearsandwich pushed a commit that referenced this pull request Mar 16, 2024
* drop python 2.7 no longer supported on github actions.

* move to noetic and focal from melodic and bionic

* pin empy to less than 4

* move from foxy to humble

* focal to jammy for humble only

* Use Ubuntu Noble for Rolling builds

Co-authored-by: Scott K Logan <logans@cottsay.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants