Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tweak the comment about files should not be edited #5463

Merged
merged 1 commit into from Apr 10, 2024

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Apr 9, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Tweak the file path in the comment so contributors can quickly find the matching script file.

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Apr 9, 2024 0:01am

Copy link

github-actions bot commented Apr 9, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#chore/tweak-caution-comments

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-dwl3zwqhc-rollup-js.vercel.app/repl/?pr=5463

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (0b665c3) to head (57d2038).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5463   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         238      238           
  Lines        9449     9449           
  Branches     2407     2407           
=======================================
  Hits         9335     9335           
  Misses         48       48           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice developer experience improvement 👍

@lukastaegert lukastaegert added this pull request to the merge queue Apr 10, 2024
Merged via the queue into master with commit 8c31e9b Apr 10, 2024
31 checks passed
@lukastaegert lukastaegert deleted the chore/tweak-caution-comments branch April 10, 2024 05:03
Copy link

This PR has been released as part of rollup@4.14.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants