Add support for ppc64le #5350

pavolloffay · 2024-01-19T07:48:12Z

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

List any relevant issue numbers:

Description

Add support for ppc64le linux gnu target.

The PR is similar to #5346. Heads up I am not working with node ecosystem. I just need to build https://github.com/jaegertracing/jaeger-ui on ppc64le which gives me at the moment:

#9 548.1 $ NODE_ENV=production REACT_APP_VSN_STATE=$(../../scripts/get-tracking-version.js) vite build
#9 553.5 /workspace/node_modules/rollup/dist/native.js:38
#9 553.5 	throw new Error(
#9 553.5 	      ^
#9 553.5 
#9 553.5 Error: Your current platform "linux" and architecture "s390x" combination is not yet supported by the native Rollup build. Please use the WASM build "@rollup/wasm-node" instead.
#9 553.5 
#9 553.5 The following platform-architecture combinations are supported:
#9 553.5 android-arm
#9 553.5 android-arm64
#9 553.5 darwin-arm64
#9 553.5 darwin-x64
#9 553.5 linux-arm
#9 553.5 linux-arm64
#9 553.5 linux-arm64 (musl)
#9 553.5 linux-riscv64
#9 553.5 linux-x64
#9 553.5 linux-x64 (musl)
#9 553.5 win32-arm64
#9 553.5 win32-ia32
#9 553.5 win32-x64
#9 553.5 
#9 553.5 If this is important to you, please consider supporting Rollup to make a native build for your platform and architecture available.
#9 553.5     at Object.<anonymous> (/workspace/node_modules/rollup/dist/native.js:38:8)
#9 553.5     at Module._compile (node:internal/modules/cjs/loader:1356:14)
#9 553.5     at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
#9 553.5     at Module.load (node:internal/modules/cjs/loader:1197:32)
#9 553.5     at Module._load (node:internal/modules/cjs/loader:1013:12)
#9 553.5     at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:202:29)
#9 553.5     at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
#9 553.5     at async ModuleLoader.import (node:internal/modules/esm/loader:336:24)
#9 553.5 
#9 553.5 Node.js v18.19.0
#9 553.6 error Command failed with exit code 1.
#9 553.6 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#9 ERROR: process "/bin/sh -c yarn install --frozen-lockfile && cd ./packages/jaeger-ui && yarn build" did not complete successfully: exit code: 1
------
 > [4/4] RUN  yarn install --frozen-lockfile && cd ./packages/jaeger-ui && yarn build:
553.5     at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
553.5     at Module.load (node:internal/modules/cjs/loader:1197:32)
553.5     at Module._load (node:internal/modules/cjs/loader:1013:12)
553.5     at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:202:29)
553.5     at ModuleJob.run (node:internal/modules/esm/module_job:195:25)
553.5     at async ModuleLoader.import (node:internal/modules/esm/loader:336:24)
553.5 
553.5 Node.js v18.19.0
553.6 error Command failed with exit code 1.
553.6 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
------
WARNING: No output specified with docker-container driver. Build result will only remain in the build cache. To push result image into registry use --push or to load image into docker use --load
Dockerfile:7
--------------------
   5 |     COPY . .
   6 |     
   7 | >>> RUN  yarn install --frozen-lockfile && cd ./packages/jaeger-ui && yarn build
   8 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c yarn install --frozen-lockfile && cd ./packages/jaeger-ui && yarn build" did not complete successfully: exit code: 1

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

vercel · 2024-01-19T07:48:17Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 28, 2024 5:37am

lukastaegert

There are still some CI issues, please have a look

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

pavolloffay · 2024-01-22T09:13:08Z

@lukastaegert could you please run the CI? I have pushed one commit to fix the issue.

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

pavolloffay · 2024-01-22T13:01:54Z

@lukastaegert could you please run the CI again? :)

pavolloffay · 2024-01-22T14:04:33Z

@lukastaegert I have filed #5354 for wasm-node to unblock our build. Any help is much appreciated

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

pavolloffay · 2024-01-22T17:02:39Z

@lukastaegert could you please run the CI again?

pavolloffay · 2024-01-22T17:28:30Z

I don't know how to solve the last build error. It seems similar to the one for s390x #5346

TODO: fix linker https://github.com/japaric/rust-cross#cross-compiling-with-cargo

lukastaegert · 2024-01-22T20:17:43Z

To my limited knowledge, these kind of errors usually mean that it tries to use the wrong linker (it actually says "linking with cc failed"). One solution sometimes is to use "zig", otherwise we need to try stuff. Cross-compilation is apparently non-trivial.

pavolloffay · 2024-01-22T20:55:04Z

Do you have any examples of using the "zig"?

Do you mean smth like this https://github.com/rollup/rollup/pull/5350/files#diff-4871c3b2dc0b429294e4a447d2b362ca146660f04622cf459b2fb8d99bc55390R136 ?

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

pavolloffay · 2024-01-22T21:54:40Z

@lukastaegert could you please enable the CI again :)

pavolloffay · 2024-01-23T08:17:54Z

zig does not seem to work

Internal Error: powerpc64le-unknown-linux-gnu can not be cross compiled by zig
    at BuildCommand.<anonymous> (/home/runner/work/rollup/rollup/node_modules/@napi-rs/cli/scripts/index.js:11446:27)
    at Generator.next (<anonymous>)
    at /home/runner/work/rollup/rollup/node_modules/@napi-rs/cli/scripts/index.js:3552:69
    at new Promise (<anonymous>)
    at __awaiter$1 (/home/runner/work/rollup/rollup/node_modules/@napi-rs/cli/scripts/index.js:3548:10)
    at BuildCommand.execute (/home/runner/work/rollup/rollup/node_modules/@napi-rs/cli/scripts/index.js:11325:16)
    at BuildCommand.validateAndExecute (/home/runner/work/rollup/rollup/node_modules/@napi-rs/cli/scripts/index.js:[21](https://github.com/rollup/rollup/actions/runs/7617255446/job/20757575020?pr=5350#step:12:22)13:37)
    at /home/runner/work/rollup/rollup/node_modules/@napi-rs/cli/scripts/index.js:3154:53
    at noopCaptureActivator (/home/runner/work/rollup/rollup/node_modules/@napi-rs/cli/scripts/index.js:3380:12)
    at Cli.run (/home/runner/work/rollup/rollup/node_modules/@napi-rs/cli/scripts/index.js:3154:30)

Any help would be appreciated. Now I am stuck again.

lukastaegert · 2024-01-23T12:58:09Z

It seems we need a profoundly new cross-compilation process. I am no expert either (otherwise, I might just have fixed things). Here https://github.com/cross-rs/cross they claim to be able to compile for those targets, one would need to figure out if this can be married to napi-rs. Or maybe there are other ways to do cross-compilation.

uweigand · 2024-03-27T13:47:09Z

Given the success we've had with s390x here #5346, I think the same approach ought to work for ppc64le as well. This means:

removing the zig: true line again; and
setting the cargo linker environment variable before the npm build call, something like

              export CARGO_TARGET_POWERPC64LE_UNKNOWN_LINUX_GNU_LINKER=powerpc64le-linux-gnu-gcc

lukastaegert

So I used my maintainer privileges and pushed the proposed changes and alas, IT WORKED! This looks good from my side now, and unless there are any concerns, I will merge and release this later today.

codecov · 2024-03-28T05:46:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.80%. Comparing base (fffaede) to head (e05cb32).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5350   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files         236      236           
  Lines        9423     9423           
  Branches     2398     2398           
=======================================
  Hits         9310     9310           
  Misses         48       48           
  Partials       65       65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Swapnali911 · 2024-03-28T05:57:19Z

Given the success we've had with s390x here #5346, I think the same approach ought to work for ppc64le as well. This means:

removing the zig: true line again; and

setting the cargo linker environment variable before the npm build call, something like
              export CARGO_TARGET_POWERPC64LE_UNKNOWN_LINUX_GNU_LINKER=powerpc64le-linux-gnu-gcc

Thanks @uweigand I have tried cross build for ppc64le and it is working as expected
cc : @omajid @tmds @alhad-deshpande @janani66

uweigand · 2024-03-28T11:23:58Z

Thanks again, @lukastaegert ! Will this be in the 4.13.2 release then?

github-actions · 2024-03-28T14:14:28Z

This PR has been released as part of rollup@4.13.2. You can test it via npm install rollup.

lukastaegert · 2024-03-28T14:16:31Z

There were some issues with the folder name but it is released now and hopefully works. Apparently, Node calls it ppc64le while Rust likes the longer powerpc64le... I hope I resolved it correctly.

uweigand · 2024-03-28T14:27:10Z

Ah, I see. This looks good to me ...

sapphi-red · 2024-03-30T14:46:16Z

native.js

@@ -16,6 +16,7 @@ const bindingsByPlatformAndArch = {
 	linux: {
 		arm: { base: 'linux-arm-gnueabihf', musl: null },
 		arm64: { base: 'linux-arm64-gnu', musl: 'linux-arm64-musl' },
+		ppc64le: { base: 'linux-ppc64le-gnu', musl: null },


@pavolloffay @lukastaegert
I guess this line and cpu field in package.json need to be ppc64 instead of ppc64le. process.arch seems to return ppc64.
https://github.com/konveyor/tackle2-ui/actions/runs/8150208242/job/22276088934#step:7:89

Looks like you are right and process.arch always returns ppc64 - which in practice means ppc64le as Node hasn't been supporting big-endian Linux for a while. In theory there is also an os.machine interface that returns either ppc64 or ppc64le, but it doesn't seem necessary to use that.

If anyone wants to make an educated PR to improve here, this would be very welcome! Otherwise, I can also have a look in the next days.

PR here: #5460

Hi @sapphi-red, just wondering whether the native ppc64le rollup work fors you now? It looks like tackle2-ui downgraded to rollup v3 in the meantime?

I don't have a ppc64le machine so I don't know 😅

I see, thanks!

I spend some hours setting up emulated smoke tests for some environments including ppc64le and I can confirm it works now 😀
#5477

github-actions · 2024-04-12T06:24:19Z

This issue has been resolved via #5460 as part of rollup@4.14.2. You can test it via npm install rollup.

Add support for ppc64le

74e5722

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

pavolloffay mentioned this pull request Jan 19, 2024

Add support for linux s390x gnu #5346

Merged

9 tasks

vercel bot deployed to Preview January 19, 2024 07:49 View deployment

lukastaegert reviewed Jan 19, 2024

View reviewed changes

Fix

23b9308

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

vercel bot deployed to Preview January 22, 2024 09:08 View deployment

Fix

4f0090d

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

vercel bot deployed to Preview January 22, 2024 12:30 View deployment

Fix

8164d4a

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

vercel bot deployed to Preview January 22, 2024 17:03 View deployment

Try enabling zig

4a98430

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>

vercel bot deployed to Preview January 22, 2024 20:59 View deployment

pavolloffay mentioned this pull request Feb 6, 2024

[Bug]: Jaeger UI does not build on IBM s390x arch (big endian) jaegertracing/jaeger-ui#2160

Closed

lukastaegert force-pushed the master branch from 5101ee6 to 8fecd35 Compare February 10, 2024 05:08

ziqi-cn mentioned this pull request Feb 26, 2024

[Feature]希望后续可以增加对loongarch 64架构的支持 clash-verge-rev/clash-verge-rev#453

Closed

tmds mentioned this pull request Mar 13, 2024

source-built aspnetcore fails during rollup on ppc64le dotnet/aspnetcore#54393

Open

Set linker via environment

e47ab30

vercel bot had a problem deploying to Preview March 28, 2024 05:35 Failure

Merge branch 'master' into add-ppc64le

e05cb32

vercel bot deployed to Preview March 28, 2024 05:37 View deployment

lukastaegert approved these changes Mar 28, 2024

View reviewed changes

lukastaegert added this pull request to the merge queue Mar 28, 2024

Merged via the queue into rollup:master with commit 1217787 Mar 28, 2024
30 checks passed

sapphi-red reviewed Mar 30, 2024

View reviewed changes

lukastaegert mentioned this pull request Apr 8, 2024

Fix ppc64le target #5460

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ppc64le #5350

Add support for ppc64le #5350

pavolloffay commented Jan 19, 2024

vercel bot commented Jan 19, 2024 •

edited

lukastaegert left a comment

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 22, 2024 •

edited

lukastaegert commented Jan 22, 2024

pavolloffay commented Jan 22, 2024 •

edited

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 23, 2024

lukastaegert commented Jan 23, 2024 •

edited

uweigand commented Mar 27, 2024

lukastaegert left a comment

codecov bot commented Mar 28, 2024

Swapnali911 commented Mar 28, 2024 •

edited

uweigand commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

lukastaegert commented Mar 28, 2024

uweigand commented Mar 28, 2024

sapphi-red Mar 30, 2024 •

edited

uweigand Apr 2, 2024

lukastaegert Apr 3, 2024

lukastaegert Apr 8, 2024

uweigand Apr 18, 2024

sapphi-red Apr 19, 2024

uweigand Apr 19, 2024

lukastaegert Apr 20, 2024

github-actions bot commented Apr 12, 2024

Add support for ppc64le #5350

Add support for ppc64le #5350

Conversation

pavolloffay commented Jan 19, 2024

Description

vercel bot commented Jan 19, 2024 • edited

lukastaegert left a comment

Choose a reason for hiding this comment

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 22, 2024 • edited

lukastaegert commented Jan 22, 2024

pavolloffay commented Jan 22, 2024 • edited

pavolloffay commented Jan 22, 2024

pavolloffay commented Jan 23, 2024

lukastaegert commented Jan 23, 2024 • edited

uweigand commented Mar 27, 2024

lukastaegert left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 28, 2024

Codecov Report

Swapnali911 commented Mar 28, 2024 • edited

uweigand commented Mar 28, 2024

github-actions bot commented Mar 28, 2024

lukastaegert commented Mar 28, 2024

uweigand commented Mar 28, 2024

sapphi-red Mar 30, 2024 • edited

Choose a reason for hiding this comment

uweigand Apr 2, 2024

Choose a reason for hiding this comment

lukastaegert Apr 3, 2024

Choose a reason for hiding this comment

lukastaegert Apr 8, 2024

Choose a reason for hiding this comment

uweigand Apr 18, 2024

Choose a reason for hiding this comment

sapphi-red Apr 19, 2024

Choose a reason for hiding this comment

uweigand Apr 19, 2024

Choose a reason for hiding this comment

lukastaegert Apr 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 12, 2024

vercel bot commented Jan 19, 2024 •

edited

pavolloffay commented Jan 22, 2024 •

edited

pavolloffay commented Jan 22, 2024 •

edited

lukastaegert commented Jan 23, 2024 •

edited

Swapnali911 commented Mar 28, 2024 •

edited

sapphi-red Mar 30, 2024 •

edited