New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for linux riscv64 gnu #5288
Conversation
Necessary for riscv64 support
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5288 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 232 232
Lines 8957 8957
Branches 2336 2336
=======================================
Hits 8852 8852
Misses 46 46
Partials 59 59 ☔ View full report in Codecov by Sentry. |
This PR has been released as part of rollup@4.7.0. You can test it via |
rollup 4.7.0 added riscv64 support: rollup/rollup#5288 Updating rollup makes it possible to build darkreader on riscv64 linux.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Bump napi-rs/cli to 2.17, which is necessary for riscv64 support.
Add support for riscv64 linux gnu target.
I would very much appreciate it if a new release with riscv64 support could be published after we get this PR merged :)