Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphs in docs, improve REPL colors #5257

Merged
merged 2 commits into from
Nov 19, 2023
Merged

Fix graphs in docs, improve REPL colors #5257

merged 2 commits into from
Nov 19, 2023

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This fixes the graphs in the plugins page by updating vite-press. It also improves readability in the REPL by using dark mode colors for code blocks (as we did in the past).

Copy link

vercel bot commented Nov 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview Nov 19, 2023 8:28pm

Copy link

github-actions bot commented Nov 19, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-docs

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-kkniz6nsw-rollup-js.vercel.app/repl/?pr=5257

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86efc76) 98.87% compared to head (7344b45) 98.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5257   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         232      232           
  Lines        8941     8941           
  Branches     2333     2333           
=======================================
  Hits         8840     8840           
  Misses         42       42           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit ce6f492 into master Nov 19, 2023
27 checks passed
@lukastaegert lukastaegert deleted the fix-docs branch November 19, 2023 20:41
Copy link

This PR has been released as part of rollup@4.5.1. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant