Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert specifying rustfmt and clippy in toolchain file as it breaks REPL build #5232

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Oct 30, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

There was an issue in a recent pipeline run that is hopefully fixed by this

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 8:28pm

@lukastaegert lukastaegert changed the title Specify toolchain components also in Github workflows Revert specifying rustfmt and clippy in toolchain file as it breaks REPL build Oct 30, 2023
@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-repl-build

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollup-rkvt8t61p-rollup-js.vercel.app/repl/?pr=5232

@lukastaegert lukastaegert merged commit 17d33a9 into master Oct 30, 2023
24 checks passed
@lukastaegert lukastaegert deleted the fix-repl-build branch October 30, 2023 20:38
@github-actions
Copy link

This PR has been released as part of rollup@4.1.6. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant