Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Vite workaround for browser build #5209

Merged

Conversation

curran
Copy link
Contributor

@curran curran commented Oct 17, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #5208

Description

Adds a brief note about the workaround required in Vite to support the browser build to the v4 migration guide.

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 6:28pm

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #5209 (5c755d8) into master (51c974d) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5209   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files         231      231           
  Lines        8849     8849           
  Branches     2314     2314           
=======================================
  Hits         8745     8745           
  Misses         43       43           
  Partials       61       61           

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for figuring that out. I knew it "should work" because the REPL uses the browser build (and is using Vite), but of course it avoids issues with npm run dev simply because that one runs against Rollup sources and not the compiled browser bundle.

@lukastaegert lukastaegert added this pull request to the merge queue Oct 18, 2023
Merged via the queue into rollup:master with commit c44a36b Oct 18, 2023
27 checks passed
@github-actions
Copy link

This PR has been released as part of rollup@4.1.5. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser build WASM path issue with Vite
2 participants