-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forceExit
CLI flag
#5195
Add forceExit
CLI flag
#5195
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is a good idea to move forward on the topic 👍 Changes look good to me.
Codecov Report
@@ Coverage Diff @@
## master #5195 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 231 231
Lines 8861 8863 +2
Branches 2316 2317 +1
=======================================
+ Hits 8756 8758 +2
Misses 44 44
Partials 61 61
|
Ah, but we would need a test. It should not be difficult to add one to |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had overlooked this one. Looks good to me, thanks for your patience!
This PR has been released as part of rollup@4.3.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This adds a new
forceExit
CLI flag which implements the core behaviour of #4969 (exit the process once Rollup is done even if there are still open handles or pending operations). Currently it doesn't implement the behaviour for watch mode but that should be trivial to add if desired.