Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: steps to enable symlinks on windows #5134

Merged
merged 1 commit into from Sep 13, 2023

Conversation

thebanjomatic
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I ran into issues running the tests on my windows machine, and it came down to git not being configured to create symlinks out of the box. I have updated the contributing guide to provide the additional steps required to be able to run the tests on windows.

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2023 10:54pm

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #5134 (8a20500) into master (642e566) will not change coverage.
Report is 7 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5134   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         226      226           
  Lines        8429     8429           
  Branches     2314     2314           
=======================================
  Hits         8340     8340           
  Misses         32       32           
  Partials       57       57           

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! As I cannot easily test on Windows, these kind of contributions are especially valuable!

@lukastaegert lukastaegert added this pull request to the merge queue Sep 13, 2023
Merged via the queue into rollup:master with commit a7d0ac1 Sep 13, 2023
12 checks passed
@github-actions
Copy link

This PR has been released as part of rollup@4.0.0-19. Note that this is a pre-release, so to test it, you need to install Rollup via npm install rollup@4.0.0-19 or npm install rollup@beta. It will likely become part of a regular release later.

@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.29.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants