-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preliminaryFileName
to OutputChunk
#5086
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Unfortunately, there are a few more things that need to be done for this feature to be release:
- The new property needs to be added to types.d.ts. Most tests fail for TypeScript errors because of this
- There is a lint issue because properties in object literals are sorted
- There should be a test asserting the value of the new property. It could be that this would already be covered in tests and they just need some adjustments. You would see when fixing the TypeScript issue and running the tests.
- The new property needs to be documented in various places. At least here and here
@lukastaegert Hi, thanks for the comment! I've pushed some more commits. However the checks seem to be not running and I don't know why... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Codecov Report
@@ Coverage Diff @@
## master #5086 +/- ##
==========================================
- Coverage 98.97% 98.96% -0.01%
==========================================
Files 226 226
Lines 8362 8391 +29
Branches 2294 2303 +9
==========================================
+ Hits 8276 8304 +28
Misses 31 31
- Partials 55 56 +1
|
This PR has been released as part of rollup@3.28.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #5080
Description