Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known globals #5072

Merged
merged 3 commits into from Jul 28, 2023
Merged

Add known globals #5072

merged 3 commits into from Jul 28, 2023

Conversation

sapphi-red
Copy link
Contributor

@sapphi-red sapphi-red commented Jul 24, 2023

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 6:15am

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #5072 (704845c) into master (dc89523) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5072   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         226      226           
  Lines        8357     8362    +5     
  Branches     2293     2294    +1     
=======================================
+ Hits         8271     8276    +5     
  Misses         31       31           
  Partials       55       55           
Files Changed Coverage Δ
src/ast/nodes/shared/knownGlobals.ts 100.00% <100.00%> (ø)

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@lukastaegert lukastaegert added this pull request to the merge queue Jul 28, 2023
Merged via the queue into rollup:master with commit 80747e3 Jul 28, 2023
12 checks passed
@sapphi-red sapphi-red deleted the add-known-globals branch July 28, 2023 12:18
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.27.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants