Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a plugin error can contains numeric code #5042

Merged
merged 2 commits into from Jun 24, 2023

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5036

Description

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 10:49am

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #5042 (c3a11d5) into master (833314c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5042   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files         225      225           
  Lines        8298     8300    +2     
  Branches     2278     2279    +1     
=======================================
+ Hits         8213     8215    +2     
  Misses         30       30           
  Partials       55       55           
Impacted Files Coverage Δ
src/utils/logs.ts 99.00% <100.00%> (+0.01%) ⬆️

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukastaegert lukastaegert added this pull request to the merge queue Jun 24, 2023
Merged via the queue into rollup:master with commit 463b31d Jun 24, 2023
12 checks passed
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.25.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin throwing Error with numeric code causes TypeError within Rollup itself
3 participants