Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm run dev #4890

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fix npm run dev #4890

merged 1 commit into from
Mar 2, 2023

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Mar 2, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

A refactoring did not take all usages of the replaced object into account. This broke the local REPL for npm run dev.

@netlify
Copy link

netlify bot commented Mar 2, 2023

Deploy Preview for rollupjs ready!

Name Link
🔨 Latest commit 5417978
🔍 Latest deploy log https://app.netlify.com/sites/rollupjs/deploys/6401059221458f0008f27e81
😎 Deploy Preview https://deploy-preview-4890--rollupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-npm-run-dev

or load it into the REPL:
https://deploy-preview-4890--rollupjs.netlify.app/repl/?pr=4890

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #4890 (5417978) into master (25bdc12) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4890   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         219      219           
  Lines        7968     7968           
  Branches     2194     2194           
=======================================
  Hits         7887     7887           
  Misses         26       26           
  Partials       55       55           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit de25554 into master Mar 2, 2023
@lukastaegert lukastaegert deleted the fix-npm-run-dev branch March 2, 2023 20:41
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.19.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants