wasm-node fails on s390x #5354
Comments
|
#5346 is a similar issue |
|
Not sure we can do anything about it, but to make this clear, the wasm-node build of this package works when run on other platforms and only fails on s390x? That would point to a bug in the WASM implementation for this platform. |
|
The build on ppc64le passed. Note that #5346 is running into a similar issue. |
|
I ran into a similar issue on IBM i. I'm curious if it is an issue of Big Endian vs. Little Endian? |
|
Ah, those are big endian systems? That would indeed be an interesting point to investigate as I was not able to test on such a system yet. So while I thought I handled endianness efficiently and correctly, I was never able to test it. Maybe it is possible to emulate such a system for debugging? |
|
It should be possible to emulate it even with docker buildx e.g. https://github.com/jaegertracing/jaeger-ui/pull/2119/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R1 |
Following up on PRs konveyor#1664 and konveyor#1739, downgrade to `rollup@^3.0`. The v4 of rollup has "native" code that runs the build, and that code does not currently work with s390 builds [1]. Since konveyor is built for x86, arm, ppc, and s390, all of those need to work. When the s390 builds can work with the wasm bits, we can upgrade to `rollup@^4.0` again. [1] - rollup/rollup#5354 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Following up on PRs #1664 and #1739, downgrade to `rollup@^3.0`. The v4 of rollup has "native" code that runs the build, and that code does not currently work with s390 builds [1]. Since konveyor is built for x86, arm, ppc, and s390, all of those need to work. When the s390 builds can work with the wasm bits, we can upgrade to `rollup@^4.0` again. [1] - rollup/rollup#5354 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
Following up on PRs #1664 and #1739, downgrade to `rollup@^3.0`. The v4 of rollup has "native" code that runs the build, and that code does not currently work with s390 builds [1]. Since konveyor is built for x86, arm, ppc, and s390, all of those need to work. When the s390 builds can work with the wasm bits, we can upgrade to `rollup@^4.0` again. [1] - rollup/rollup#5354 Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
…1738) ## Summary Refactor and enhance branding capabilities. Now branding is included from a single directory that contains at least `strings.json`, `manifest.json`, and `favicon.ico`. Any other assets may be placed in the directory and will be copied to the bundled app. Running the build as normal should show no difference. Running the build with `BRANDING=./some-other-brand npm run start:dev` will try to use a branding from the specified directory (that is relative to the project's source root). See `BRANDING.md` for more details. Resolves: #1682 ## Details Branding changes: - Move Konveyor branding assets to a project top-level branding directory - Remove MTA branding assets - Remove profile/branding constants from `env` and client module - Embed branding strings and assets in the common module - `strings.json` is templated to allow the build to adjust asset URL path roots as necessary - `brandingAssetPath()` - server's index.html generation sources the template strings from the common module's branding strings - `HeaderApp` and `AppAboutModal` components support branding by using the `useBranding` hook - `BRANDING` as a relative path is computed from the project root - webpack build source branding assets directly from the common module - Unit tests, snapshots and jest configs updated as necessary Jest changes: - Use `react-i18next` mock from `client/__mocks__` as a more robust mock borrowed from react-i18n repos - Move `setupTests.ts` into `client/src/app/test-config` to keep jest test config code all in the same directory Related changes: - add new rollup plugins (copy, virtual) ## Downgrade to rollup v3 for multiarch builds (#1742) As a followup on PRs #1664 and #1739, it became necessary to downgrade back to `rollup@^3.0`. The v4 of rollup has "native" code that runs the build, and that code does not currently work with s390 builds [1]. Since konveyor is built for x86, arm, ppc, and s390, all of those need to work. When the s390 builds can work with the wasm bits, we can upgrade to `rollup@^4.0` again. [1] - rollup/rollup#5354 --------- Signed-off-by: Scott J Dickerson <sdickers@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: Ian Bolton <ibolton@redhat.com>
|
I am closing this. We were able to build the jaeger-ui with the native x390s jaegertracing/jaeger-ui#2160 |
Rollup Version
4.9.5
Operating System (or Browser)
s390x
Node Version (if applicable)
18
Link To Reproduction
jaegertracing/jaeger-ui#2119
Expected Behaviour
Be able to build jaegertracing/jaeger-ui#2119 with
wasm-nodes390xe.g.
docker buildx build --progress plain --platform linux/s390x --tag pavolloffay/jaeger-ui:s390x --build-arg=TARGETARCH=s390x -f ./Dockerfile .Actual Behaviour
More details and reproducer is in jaegertracing/jaeger-ui#2119
The text was updated successfully, but these errors were encountered: