fix: don't pass external modules to the manualChunks function (#5068)

* fix: don't pass external modules to the manualChunks function

* tweak

src/Bundle.ts

@@ -22,7 +22,6 @@ import {
 	error,
 	logCannotAssignModuleToChunk,
 	logChunkInvalid,
-	logExternalModulesCannotBeIncludedInManualChunks,
 	logInvalidOption
 } from './utils/logs';
 import type { OutputBundleWithPlaceholders } from './utils/outputBundle';
@@ -129,12 +128,10 @@ export default class Bundle {
 			getModuleInfo: this.graph.getModuleInfo
 		};
 		for (const module of this.graph.modulesById.values()) {
-			const manualChunkAlias = getManualChunk(module.id, manualChunksApi);
-			if (typeof manualChunkAlias === 'string') {
-				if (module instanceof Module) {
+			if (module instanceof Module) {
+				const manualChunkAlias = getManualChunk(module.id, manualChunksApi);
+				if (typeof manualChunkAlias === 'string') {
 					manualChunkAliasesWithEntry.push([manualChunkAlias, module]);
-				} else {
-					return error(logExternalModulesCannotBeIncludedInManualChunks(module.id));
 				}
 			}
 		}

test/form/samples/external-modules-could-not-be-passed-to-the-manualChunks/_config.js

@@ -0,0 +1,19 @@
+const text = "External modules couldn't be passed to the manualChunks.";
+
+module.exports = defineTest({
+	description: text,
+	options: {
+		external: id => {
+			if (id.endsWith('external.js')) {
+				return true;
+			}
+		},
+		output: {
+			manualChunks(id) {
+				if (id.endsWith('external.js')) {
+					throw new Error(text);
+				}
+			}
+		}
+	}
+});

test/form/samples/external-modules-could-not-be-passed-to-the-manualChunks/main.js

@@ -0,0 +1 @@
+import './external.js';