Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terser): expose extended terser options interface #1477

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

tada5hi
Copy link
Member

@tada5hi tada5hi commented Apr 7, 2023

Rollup Plugin Name: terser

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

fixes #1474

@tada5hi tada5hi requested a review from shellscape April 7, 2023 20:11
Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change, feel free to merge

@tada5hi
Copy link
Member Author

tada5hi commented Apr 8, 2023

@shellscape I would also like to increase the dependency version of the packages esm-shim, swc and terser plugin soon, would you prefer to wait with the merge of the fix here under the background or do you see no problem in it if in relatively short time a further patch release takes place ?

I would make a batch pull request for this or should I address the version dumps individually ?

@shellscape
Copy link
Collaborator

Since this is a fix, it should roll out immediately.

@tada5hi tada5hi merged commit 6f0a441 into rollup:master Apr 9, 2023
14 checks passed
@tada5hi tada5hi deleted the terser branch May 17, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin-terser] types exported is not same as source
2 participants