fix: make rollbar compatible with webpack #936

andrei-bitca-dc · 2021-03-19T11:29:40Z

Description of the change

Rollbar is not working when using @vercel/ncc to build. It points to the project package.json, instead of rollbar's one, therefore getting:

TypeError: Cannot read property 'server' of undefined at Object.3029 (/var/webpack:/node_modules/rollbar/src/server/rollbar.js:659:1)

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
"Ready for review" label attached to the PR and reviewers mentioned in a comment
Changes have been reviewed by at least one other engineer
Issue from task tracker has a link to this pull request

waltjones · 2021-03-19T12:06:27Z

src/server/rollbar.js


-var packageJson = require('../../package.json');
+var packageJson = require(path.join(__dirname, '../../package.json'));


Why does the path only resolve incorrectly here, and not for any of the following relative paths?

I think because it's the package.json file and it's not included in the dist.

However, using path.join for dynamic imports won't work with esbuild, as it doesn't support dynamic imports yet (evanw/esbuild#700).

fix: make rollbar compatible with webpack

17c5193

waltjones reviewed Mar 19, 2021

View reviewed changes

andrei-bitca-dc closed this May 5, 2021


		var packageJson = require('../../package.json');
		var packageJson = require(path.join(__dirname, '../../package.json'));