Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rack deprecation warning #1142

Merged
merged 1 commit into from Jan 3, 2024
Merged

Fix rack deprecation warning #1142

merged 1 commit into from Jan 3, 2024

Conversation

waltjones
Copy link
Contributor

Description of the change

The warning message:

warning: Request#[] is deprecated and will be removed in a future version of Rack. Please use request.params[] instead

This helper has been around since Rack 1.x and was deprecated in Rack 2.x.

The fix includes to_s on the key, as the helper did.

Type of change

  • Maintenance

Related issues

Fixes: #1134

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached

@waltjones waltjones merged commit 0eced3d into master Jan 3, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudetroit mudetroit mudetroit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning in Rack 3
2 participants
@waltjones @mudetroit