Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gotooltest: run probe commands in temporary directory #188

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Nov 21, 2022

(see commit message)

gotooltest/setup_test.go Outdated Show resolved Hide resolved
gotooltest/setup_test.go Outdated Show resolved Hide resolved
gotooltest/setup.go Outdated Show resolved Hide resolved
Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo @mvdan's suggestions, thanks.

This ensures we don't make any assumptions about the caller's working
directory, which might contain an invalid go.mod, for example.
@myitcv
Copy link
Collaborator Author

myitcv commented Nov 21, 2022

@mvdan - changes made. PTAL.

@myitcv myitcv merged commit c7b2344 into master Nov 21, 2022
@myitcv myitcv deleted the gotooltest_temp_dir branch November 21, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants