Upgrade V8 binaries for 10.9.194.9 version **working** #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update github workflow to use go 18 & 19 - Update github workflow to use macos-latest - Update github build workflow to use ubuntu 22.04 - Add gitignore for jetbrains and .gclient_previous files - Switch cgo build to C++17 and enable sandbox at build time - Update test with update to date error message - Remove no longer supported build flag. - Move initialization to v8go.go and include flag set to avoid flag freezing - Reorder initialization so allocator is initialized after v8 (required by latest v8)
Auto-generated pull request to build V8 for ubuntu-22.04 x86_64
Auto-generated pull request to build V8 for macos-11 x86_64
Auto-generated pull request to build V8 for macos-11 arm64
Auto-generated pull request to build V8 for ubuntu-22.04 arm64
github-actions
bot
force-pushed
the
v8_10.9.194.9_upgrade
branch
from
cf5d3d8
to
03703b2
Compare
|
Quick fyi. The automated update on our repo seems to have overwritten this pr branch. Will fix shortly. |
|
FYI, this was reopened as #363 since the automation was overwriting a branch with this name (as best I can tell). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use existing workflows to build latest V8 artifacts as well as code changes to ensure v8go continues to work.
Includes:
freezing
by latest v8)
Commits are kept separate with merges to certify provenance of all library objects built using existing rogchap/v8go mechanisms.