Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SnapshotCreator API #281

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Add SnapshotCreator API #281

wants to merge 13 commits into from

Commits on Jan 28, 2022

  1. Add SnapshotCreator API 

    Co-authored-by: Genevieve <genevieve.lesperance@shopify.com>
    @GustavoCaso
    2 people authored and GustavoCaso committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    6b4e736 View commit details
    Browse the repository at this point in the history

  2. Improve error message for NewContextFromSnapshot

    @GustavoCaso
    GustavoCaso committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    b6360e2 View commit details
    Browse the repository at this point in the history

  3. add documentation for the new API

    @GustavoCaso
    GustavoCaso committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    44297f8 View commit details
    Browse the repository at this point in the history

  4. cleanup tests

    @GustavoCaso
    GustavoCaso committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    88b05d0 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary check for nullptr

    @GustavoCaso
    GustavoCaso committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    b66880e View commit details
    Browse the repository at this point in the history

  6. handle errors when calling NewContextFromSnapshot at V8 level

    @GustavoCaso
    GustavoCaso committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    fbf1281 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Update CHANGELOG

    @GustavoCaso
    GustavoCaso committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    ebdfa43 View commit details
    Browse the repository at this point in the history

  2. fix typos

    @GustavoCaso
    GustavoCaso committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    acaa5fb View commit details
    Browse the repository at this point in the history

  3. make sure pointer to snapshot creator is nil after disposing it

    @GustavoCaso
    GustavoCaso committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    4030029 View commit details
    Browse the repository at this point in the history

  4. move defer call

    @GustavoCaso
    GustavoCaso committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    ef9e910 View commit details
    Browse the repository at this point in the history

  5. clean some C++ code

    @GustavoCaso
    GustavoCaso committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    eec9dcd View commit details
    Browse the repository at this point in the history

  6. improve comments on SnapshotCreator.Create

    @GustavoCaso
    GustavoCaso committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    ebb5fa8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into GustavoCaso/SnapshotCreator

    Genevieve committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    3a6bb0f View commit details
    Browse the repository at this point in the history