Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use length to ensure null chars do not cause early termination of C string copies/reads #272

Merged
merged 13 commits into from Jan 12, 2022
Merged

Use length to ensure null chars do not cause early termination of C string copies/reads #272

merged 13 commits into from Jan 12, 2022

Commits on Jan 6, 2022

  1. Intro test case for null terminator string

    Genevieve L'Esperance committed Jan 6, 2022
    Copy the full SHA
    1611ced View commit details
    Browse the repository at this point in the history

  2. unexpected result: expected ss, got sx00s

    Genevieve L'Esperance committed Jan 6, 2022
    Copy the full SHA
    1911ffa View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Fix the assertion, add Unicode symbols

    Maxim Shirshin committed Jan 7, 2022
    Copy the full SHA
    b7bbe79 View commit details
    Browse the repository at this point in the history

  2. Pass go string length into v8::String::New to ensure it does not cut off 

    at null chars
    Genevieve L'Esperance committed Jan 7, 2022
    Copy the full SHA
    3348d80 View commit details
    Browse the repository at this point in the history

  3. Reuse the existing RtnString type

    Genevieve L'Esperance committed Jan 7, 2022
    Copy the full SHA
    8eb8550 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Merge branch 'master' into sws-722

    Genevieve committed Jan 11, 2022
    Copy the full SHA
    7a9bb8e View commit details
    Browse the repository at this point in the history

  2. Formatting

    Genevieve L'Esperance committed Jan 11, 2022
    Copy the full SHA
    6009677 View commit details
    Browse the repository at this point in the history

  3. Update value_test.go 

    Co-authored-by: Dylan Thacker-Smith <dylan.smith@shopify.com>
    @dylanahsmith
    Genevieve and dylanahsmith committed Jan 11, 2022
    Copy the full SHA
    f6accef View commit details
    Browse the repository at this point in the history

  4. Table tests for NewValue

    Genevieve L'Esperance committed Jan 11, 2022
    Copy the full SHA
    1942901 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Merge branch 'master' into sws-722

    Genevieve committed Jan 12, 2022
    Copy the full SHA
    d572da3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into sws-722

    Genevieve committed Jan 12, 2022
    Copy the full SHA
    941957d View commit details
    Browse the repository at this point in the history

  3. Use std::string constructor in CopyString(Utf8Value) to keep whole 

    string
    Genevieve L'Esperance committed Jan 12, 2022
    Copy the full SHA
    396ce4d View commit details
    Browse the repository at this point in the history

  4. Update changelog

    Genevieve L'Esperance committed Jan 12, 2022
    Copy the full SHA
    1361f8e View commit details
    Browse the repository at this point in the history