Skip to content

Commit

Permalink
Prefix Version function with V8go prefix
Browse files Browse the repository at this point in the history
  • Loading branch information
dylanahsmith committed Jun 21, 2022
1 parent 199c109 commit d0ac2ad
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion v8go.cc
Expand Up @@ -1615,7 +1615,7 @@ ValuePtr FunctionSourceMapUrl(ValuePtr ptr) {

/********** v8::V8 **********/

const char* Version() {
const char* V8goVersion() {
return V8::GetVersion();
}

Expand Down
4 changes: 2 additions & 2 deletions v8go.go
Expand Up @@ -16,8 +16,8 @@ import (
)

// Version returns the version of the V8 Engine with the -v8go suffix
func Version() string {
return C.GoString(C.Version())
func V8goVersion() string {
return C.GoString(C.V8goVersion())
}

// SetFlags sets flags for V8. For possible flags: https://github.com/v8/v8/blob/master/src/flags/flag-definitions.h
Expand Down
2 changes: 1 addition & 1 deletion v8go.h
Expand Up @@ -298,7 +298,7 @@ extern RtnValue FunctionCall(ValuePtr ptr,
RtnValue FunctionNewInstance(ValuePtr ptr, int argc, ValuePtr args[]);
ValuePtr FunctionSourceMapUrl(ValuePtr ptr);

const char* Version();
const char* V8goVersion();
extern void SetFlags(const char* flags);

#ifdef __cplusplus
Expand Down

0 comments on commit d0ac2ad

Please sign in to comment.