Skip to content

Commit

Permalink
Remove unnecessary nested Locker and Isolate::Scope use (#275)
Browse files Browse the repository at this point in the history
* Remove unnecessary nested Locker and Isolate::Scope use

* Make ExceptionError static, since it isn't used outside that file
  • Loading branch information
dylanahsmith committed Jan 12, 2022
1 parent ede7cee commit c0dbfd3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions v8go.cc
Expand Up @@ -61,9 +61,9 @@ const char* CopyString(String::Utf8Value& value) {
return CopyString(*value);
}

RtnError ExceptionError(TryCatch& try_catch, Isolate* iso, Local<Context> ctx) {
Locker locker(iso);
Isolate::Scope isolate_scope(iso);
static RtnError ExceptionError(TryCatch& try_catch,
Isolate* iso,
Local<Context> ctx) {
HandleScope handle_scope(iso);

RtnError rtn = {nullptr, nullptr, nullptr};
Expand Down

0 comments on commit c0dbfd3

Please sign in to comment.