Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings of AndroidSdk.groovy #8503

Merged
merged 1 commit into from Oct 28, 2023
Merged

Fix warnings of AndroidSdk.groovy #8503

merged 1 commit into from Oct 28, 2023

Conversation

utzcoz
Copy link
Member

@utzcoz utzcoz commented Oct 7, 2023

  1. Add necessary override for equals and hasCode implementations.
  2. Make some methods static as they return the same content very invoking.

@utzcoz utzcoz requested a review from hoisie October 7, 2023 07:34
@utzcoz
Fix warnings of AndroidSdk.groovy
dc6f342 
1. Add necessary override for equals and hasCode implementations.
2. Make some methods static as they return the same content very
   invoking.

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz
Copy link
Member Author

utzcoz commented Oct 28, 2023

@hoisie It looks safe, so I merge it.

@utzcoz utzcoz merged commit 5f83869 into robolectric:master Oct 28, 2023
18 checks passed
@utzcoz utzcoz deleted the fix-AndroidSdk-warnings branch October 28, 2023 07:12
@Jvr2022 Jvr2022 mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoisie hoisie Awaiting requested review from hoisie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@utzcoz