Future proof ShadowViewGroupTest#hasFocus_shouldReturnTrueIfAnyChildHasFocus. #8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_515781340
branch
7 times, most recently
from
058f7c0
to
50bac4b
Compare
…asFocus. An upcoming platform change will ignore focus requests if views are not attached to a window. So modify the test to host the views in an Activity. PiperOrigin-RevId: 516932208
copybara-service
bot
force-pushed
the
piper_515781340
branch
from
50bac4b
to
a6eeae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future proof ShadowViewGroupTest#hasFocus_shouldReturnTrueIfAnyChildHasFocus.
An upcoming platform change will ignore focus requests if views are not attached to a window.
So modify the test to host the views in an Activity.