Skip to content

Commit

Permalink
Merge pull request #297 from robcresswell/feat/fix-294
Browse files Browse the repository at this point in the history
feat: correct aria-hidden behaviour, update icons
  • Loading branch information
robcresswell committed Jan 28, 2024
2 parents 4b79bae + bf27c16 commit 18eed36
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const dist = path.resolve(__dirname, 'dist');
function renderTemplate(title: string, svgPathData: string, name: string) {
return `<template>
<span v-bind="$attrs"
:aria-hidden="!title"
:aria-hidden="title ? null : true"
:aria-label="title"
class="material-design-icon ${title}-icon"
role="img"
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"devDependencies": {
"@babel/core": "^7.20.12",
"@babel/preset-env": "^7.20.2",
"@mdi/js": "7.1.96",
"@mdi/js": "7.4.47",
"@types/node": "^18.11.18",
"@vue/test-utils": "1.2.2",
"babel-core": "7.0.0-bridge.0",
Expand Down

0 comments on commit 18eed36

Please sign in to comment.