Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement MovePointShapeAnimator and ChangeLineOffsetsShapeAnimator #3281

Merged
merged 122 commits into from
Feb 23, 2024
Merged

feat: implement MovePointShapeAnimator and ChangeLineOffsetsShapeAnimator #3281

merged 122 commits into from
Feb 23, 2024

Conversation

naftalibeder
Copy link
Collaborator

@naftalibeder naftalibeder commented Dec 19, 2023 •
edited

Description

This implements the specific shape animators for animating a single point source and a line by its offsets.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Videos

Screen.Recording.2024-01-30.at.2.20.43.PM.mov
Screen.Recording.2024-01-30.at.2.21.10.PM.mov

@naftalibeder naftalibeder marked this pull request as draft December 19, 2023 21:43
mfazekas
mfazekas requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naftalibeder thanks much for looking into it. Looks good to me 👍 , some notes in the review!

ios/RNMBX/ShapeAnimators/ShapeAnimatorCommon.swift Show resolved Hide resolved
ios/RNMBX/ShapeAnimators/ShapeAnimatorCommon.swift Outdated Show resolved Hide resolved
src/Mapbox.ts Outdated Show resolved Hide resolved
src/shape_animators/MovePointShapeAnimator.ts Outdated Show resolved Hide resolved
@naftalibeder
Copy link
Collaborator Author

@mfazekas So what is left on this before you'd be comfortable merging it?

@mfazekas
Copy link
Contributor

@mfazekas So what is left on this before you'd be comfortable merging it?

The biggest issue is that all iOS CI fails. I don't see the error message.

@naftalibeder
Copy link
Collaborator Author

@mfazekas All checks passed :)

@mfazekas mfazekas merged commit c5d94e6 into rnmapbox:main Feb 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfazekas mfazekas mfazekas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@naftalibeder @mfazekas