Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Pass changed boolean array to derived callbacks #1

Draft
wants to merge 1 commit into
base: feature/update-and-set-for-stores
Choose a base branch
from

Conversation

rmunn
Copy link
Owner

@rmunn rmunn commented Sep 29, 2021

This allows the callbacks to easily run complex update logic based on which store changed most recently.

This PR is based on sveltejs#6750 since sveltejs#6750 also changes the function signature of the derived callback. If this PR was merged without sveltejs#6750, then it would make sveltejs#6750 more difficult to merge since the derived callback would then have to have the signature (stores, set, changedArray, update) which is much uglier than (stores, set, update, changedArray). So I want to wait for sveltejs#6750 to be merged (or rejected) first, then a decision can be made on this PR.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

This allows the callbacks to easily run complex update logic based on
which store changed most recently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant