- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a bug causing duplicate user-agent headers when using a shared HttpClient
.
#2008
Fixed a bug causing duplicate user-agent headers when using a shared HttpClient
.
#2008
Conversation
I'm not seeing why the test is exiting with code 1. I'm more than willing to make adjustments if needed. Can someone help me identify what's going wrong there? |
Nevermind, I found it. Failed 1 test, it was hidden away at first. I'll review and update once resolved. |
After local review, the test in question fails in the |
Deprecated by #2010 |
@alexeyzimarev, I reviewed the files changed in #2010 and don't see where this was accounted for. Was the correct item linked? |
Ah sorry. I might have messed up. Let me check it now. Apologies! |
@tacosontitan Cloud you check the message from the CLA bot? It's a new thing from .NET Foundation, would be nice if you can do what it asks. |
@dotnet-policy-service agree |
@alexeyzimarev, no problem, also had to update the PR with the latest changes in |
Description
This PR fixes issue #1990 by using string interpolation to concatenate the
Product
andVersion
properties in a way that matches theUserAgent
property ofRestClientOptions
.Purpose
This pull request is a:
Checklist