Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User Agent without validation. #1973

Merged

Conversation

alekw
Copy link
Contributor

@alekw alekw commented Nov 17, 2022

Description

Add User Agent without validation. It will allow usage of any string as User Agent. Useful for imitating other user agents.
Previous implementation has forbidden multiple characters, which are used in other http clients (not only .net).

#1943
#1905

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Sorry, something went wrong.

@dnfadmin
Copy link

dnfadmin commented Nov 17, 2022

CLA assistant check
All CLA requirements met.

@alexeyzimarev
Copy link
Member

Thank you for the PR. Please remember to sign the CLA.

@alekw
Copy link
Contributor Author

alekw commented Nov 18, 2022

Thank you for the PR. Please remember to sign the CLA.

Yesterday I had some problems with signing CLA, today I have managed.

@alexeyzimarev alexeyzimarev merged commit 28b5478 into restsharp:dev Nov 18, 2022
@alekw alekw deleted the feature/alekw/UserAgentWithoutValidation branch November 18, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants