Move Cookie handling out of HttpClient so we do not cross pollinate requests #1966
+165
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang I was not updated to dev. Will rebase it all and fix it up now. |
kendallb
force-pushed
the
feature/move-cookies-out-of-httpclient
branch
from
d56bfd4 to
3cd8331
Compare
…y will not cross pollinate requests. Make the CookieContainer a property on the request, not the client. Add tests for cookie handling.
kendallb
force-pushed
the
feature/move-cookies-out-of-httpclient
branch
from
3cd8331 to
37e7d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the following:
Purpose
This pull request is a:
although the breakage is only against stuff that was not released other than in alpha anyway (making Options internal again).
Checklist