Remove thread_safe arg in Redis instantiations #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new redis gem 5.0.x checks for valid args and throws on this call.
|
Thinking we'll roll with this and run it against CI... if there's no other issues, we'll do a quick patch release to support redis-rb 5.0. If there's more problems, we can pull in your other PR and do a patch release to temporarily pin to 4.x until we get the 5.0 issues worked out. |
|
hey @PatrickTulskie any news on releasing this? |
|
@sl0thentr0py Yep! There were a few other things that had to be addressed for Redis 5 compatibility before release though. Prepping a build this evening and hoping to ship tomorrow AM. Just didn't want to release it on Labor Day. |
|
cool, thank you and much appreciated! |
|
@sl0thentr0py This is now pushed in 2.4.0. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new redis gem 5.0.x checks for valid args and throws on this call.
Fixes #1821