Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve biome config #436

Merged

Conversation

eugene-yaroslavtsev
Copy link

  • use schema from node_modules - makes biome schema, by definition, always be in sync with installed biome version
  • use .jsonc to support comments
  • standardize to single quotes for JSX as well
  • only run checks against files changed relative to main branch
  • inherit ignored files from .gitignore
  • upgrade usage of soon-to-be deprecated --fix command

Verified

This commit was signed with the committer’s verified signature.
reta Andriy Redko
- use schema from node_modules - makes biome schema, by definition, always be in sync with installed biome version
- use .jsonc to support comments
- standardize to single quotes for JSX as well
- only run checks against files changed relative to main branch
- inherit ignored files from .gitignore
- upgrade usage of soon-to-be deprecated `--fix` command
@eugene-yaroslavtsev eugene-yaroslavtsev requested a review from a team as a code owner October 5, 2024 02:29
@bukinoshita bukinoshita changed the title feat: improve biome config feat: Improve biome config Oct 25, 2024
@bukinoshita
Copy link
Member

  • use schema from node_modules - makes biome schema, by definition, always be in sync with installed biome version
  • use .jsonc to support comments
  • standardize to single quotes for JSX as well
  • only run checks against files changed relative to main branch
  • inherit ignored files from .gitignore
  • upgrade usage of soon-to-be deprecated --fix command

Nice, this is great!

@bukinoshita bukinoshita merged commit 16e954f into resend:main Oct 25, 2024
6 checks passed
vcapretz pushed a commit that referenced this pull request Nov 18, 2024
@eugene-yaroslavtsev eugene-yaroslavtsev deleted the chore/improve-biome-config branch December 17, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants