feat: Add email scheduling #33
Merged
+326
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kewynakshlley
commented
Aug 15, 2024
kewynakshlley
commented
- Create email with schedule
- Update email schedule
- Cancel schedule
- Removed date types
| * @param scheduledAt The schedule of the email in ISO 8601 format (e.g., 2024-08-05T11:52:01.858Z). | ||
| * @return This builder instance for method chaining. | ||
| */ | ||
| public Builder scheduledAt(String scheduledAt) { |
There was a problem hiding this comment.
Should we instead use withScheduledAt in the Builder? If this is how it's done in the others Builders, I vote to keep consistent, but if this is the first, I think that using the with prefix makes more sense with the Builder way
There was a problem hiding this comment.
I don't use the 'with' prefix in the other builders. I would prefer to keep it this way without the 'with' prefix to keep the code consistent.
felipevolpone
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.