-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hawk to 7.0.7 #2880
Update hawk to 7.0.7 #2880
Conversation
This was a breaking change in my case, the new version of hawk has a node engine of >= 8 and it's sntp dependency has We run code with request on lambda which doesn't go higher than 6.10 and we don't normally compile dependencies with babel (not sure if this is expected). |
same problem here. Please revert that ASAP!! |
+1 |
3 similar comments
+1 |
+1 |
+1 |
Well... this is bad. |
+1 |
1 similar comment
+1 |
+1 |
That's why you shouldn't ignore CI builds - https://travis-ci.org/request/request/jobs/345197366 :D |
+1 |
1 similar comment
+1 |
Interestingly travis-ci is still "red" also for the revert commit |
Finally found this! thanks for the quick fix. |
More information about why this PR was reverted here: #2891 (comment) |
PR Checklist:
npm test
locally and all tests are passing.PR Description