-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating tough-cookie due to security fix. #2776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thanks for updating 😉
Please don't update the version of request. The release script does that on its own :) Other than that, it looks good. |
[tough-cookie vulnerability](https://nodesecurity.io/advisories/525) [request update](request/request#2776)
ff52bc1
to
1d55248
Compare
@mikeal All done! |
Any chance this can be merged today? I'd like to update my project ASAP 😃 |
Could this be merged soon to fix all the failing CI builds 😄 ? |
The security advisories have already been updated with the patched release of Can we please have a release of |
this merge is great but when I try to update with |
@appility That is because the latest published version is |
[tough-cookie vulnerability](https://nodesecurity.io/advisories/525) [request update](request/request#2776)
[tough-cookie vulnerability](https://nodesecurity.io/advisories/525) [request update](request/request#2776)
Updating request to 2.83 due to security fix of the tough-cookie dependecy. [tough-cookie vulnerability](https://nodesecurity.io/advisories/525) [request update](request/request#2776)
due to security fix of the tough-cookie dependecy. [tough-cookie vulnerability](https://nodesecurity.io/advisories/525) [request update](request/request#2776)
due to security fix of the tough-cookie dependecy. [tough-cookie vulnerability](https://nodesecurity.io/advisories/525) [request update](request/request#2776)
Enforce our users to upgrade to a recent request version that contains latest security fixes: - tough-cookie vulnerability: https://nodesecurity.io/advisories/525 - request update: request/request#2776
Enforce our users to upgrade to a recent request version that contains latest security fixes: - tough-cookie vulnerability: https://nodesecurity.io/advisories/525 - request update: request/request#2776
To include security fixes in `tough-cookie` request/request#2776 https://nodesecurity.io/advisories/130 https://nodesecurity.io/advisories/525
PR Checklist:
npm test
locally and all tests are passing.PR Description
This addresses: