Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/sbt): Improve scala 3 dependencies handling and meta-build classes #29155

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

ArtyomGabeev
Copy link
Contributor

@ArtyomGabeev ArtyomGabeev commented May 19, 2024

Changes

  1. Parse build.sbt first and pass scalaVersion to remaining files if defined.

Context

Fixes:
#29127

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented May 19, 2024

CLA assistant check
All committers have signed the CLA.

@ArtyomGabeev ArtyomGabeev changed the title Improve scala 3 dependencies handling and meta-build classes feat(manager/sbt): Improve scala 3 dependencies handling and meta-build classes May 19, 2024
@rarkins
Copy link
Collaborator

rarkins commented May 30, 2024

Is there any overlap/conflict with #29291 which needs to be considered?

@ArtyomGabeev
Copy link
Contributor Author

Yes, Ill rebase and clean up pr, it is already covered in mentioned pr

@ArtyomGabeev
Copy link
Contributor Author

Is there any overlap/conflict with #29291 which needs to be considered?

I've rebased, performed clean-up, tested locally and updated description.

@rarkins rarkins added this pull request to the merge queue Jun 1, 2024
Merged via the queue into renovatebot:main with commit 5c472e4 Jun 1, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.385.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants